mirror of
https://github.com/sysadminsmedia/homebox.git
synced 2025-12-21 13:23:14 +01:00
* ent re-generation
* add oidc integration
* document oidc integration
* go fmt
* address backend linter findings
* run prettier on index.vue
* State cookie domain can mismatch when Hostname override is used (breaks CSRF check). Add SameSite.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Delete state cookie with matching domain and MaxAge; add SameSite.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Fix endpoint path in comments and error to include /api/v1.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Also use request context when verifying the ID token.
* Do not return raw auth errors to clients (user-enumeration risk).
* consistently set cookie the same way across function
* remove baseURL after declaration
* only enable OIDC routes if OIDC is enabled
* swagger doc for failure
* Only block when provider=local; move the check after parsing provider
* fix extended session comment
* reduce pii logging
* futher reduce pii logging
* remove unused DiscoveryDocument
* remove unused offline_access from default oidc scopes
* remove offline access from AuthCodeURL
* support host from X-Forwarded-Host
* set sane default claim names if unset
* error strings should not be capitalized
* Revert "run prettier on index.vue"
This reverts commit aa22330a23.
* Add timeout to provider discovery
* Split scopes robustly
* refactor hostname calculation
* address frontend prettier findings
* add property oidc on type APISummary
* LoginOIDC: Normalize inputs, only create if not found
* add oidc email verification
* oidc handleCallback: clear state cookie before each return
* add support for oidc nonce parameter
* Harden first-login race: handle concurrent creates gracefully and fix log key.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* support email verified claim as bool or string
* fail fast on empty email
* PKCE verifier
* fix: add timing delay to attachment test to resolve CI race condition
The attachment test was failing intermittently in CI due to a race condition
between attachment creation and retrieval. Adding a small 100ms delay after
attachment creation ensures the file system and database operations complete
before the test attempts to verify the attachment exists.
* Revert "fix: add timing delay to attachment test to resolve CI race condition"
This reverts commit 4aa8b2a0d829753e8d2dd1ba76f4b1e04e28c45e.
* oidc error state, use ref
* rename oidc.force to oidc.authRedirect
* remove hardcoded oidc error timeout
* feat: sub/iss based identity matching and userinfo endpoint collection
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Matthew Kilgore <matthew@kilgore.dev>
318 lines
8.9 KiB
Go
318 lines
8.9 KiB
Go
package v1
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/hay-kot/httpkit/errchain"
|
|
"github.com/hay-kot/httpkit/server"
|
|
"github.com/rs/zerolog/log"
|
|
"github.com/sysadminsmedia/homebox/backend/internal/core/services"
|
|
"github.com/sysadminsmedia/homebox/backend/internal/sys/validate"
|
|
)
|
|
|
|
const (
|
|
cookieNameToken = "hb.auth.token"
|
|
cookieNameRemember = "hb.auth.remember"
|
|
cookieNameSession = "hb.auth.session"
|
|
)
|
|
|
|
type (
|
|
TokenResponse struct {
|
|
Token string `json:"token"`
|
|
ExpiresAt time.Time `json:"expiresAt"`
|
|
AttachmentToken string `json:"attachmentToken"`
|
|
}
|
|
|
|
LoginForm struct {
|
|
Username string `json:"username" example:"admin@admin.com"`
|
|
Password string `json:"password" example:"admin"`
|
|
StayLoggedIn bool `json:"stayLoggedIn"`
|
|
}
|
|
)
|
|
|
|
type CookieContents struct {
|
|
Token string
|
|
ExpiresAt time.Time
|
|
Remember bool
|
|
}
|
|
|
|
func GetCookies(r *http.Request) (*CookieContents, error) {
|
|
cookie, err := r.Cookie(cookieNameToken)
|
|
if err != nil {
|
|
return nil, errors.New("authorization cookie is required")
|
|
}
|
|
|
|
rememberCookie, err := r.Cookie(cookieNameRemember)
|
|
if err != nil {
|
|
return nil, errors.New("remember cookie is required")
|
|
}
|
|
|
|
return &CookieContents{
|
|
Token: cookie.Value,
|
|
ExpiresAt: cookie.Expires,
|
|
Remember: rememberCookie.Value == "true",
|
|
}, nil
|
|
}
|
|
|
|
// AuthProvider is an interface that can be implemented by any authentication provider.
|
|
// to extend authentication methods for the API.
|
|
type AuthProvider interface {
|
|
// Name returns the name of the authentication provider. This should be a unique name.
|
|
// that is URL friendly.
|
|
//
|
|
// Example: "local", "ldap"
|
|
Name() string
|
|
// Authenticate is called when a user attempts to login to the API. The implementation
|
|
// should return an error if the user cannot be authenticated. If an error is returned
|
|
// the API controller will return a vague error message to the user.
|
|
//
|
|
// Authenticate should do the following:
|
|
//
|
|
// 1. Ensure that the user exists within the database (either create, or get)
|
|
// 2. On successful authentication, they must set the user cookies.
|
|
Authenticate(w http.ResponseWriter, r *http.Request) (services.UserAuthTokenDetail, error)
|
|
}
|
|
|
|
// HandleAuthLogin godoc
|
|
//
|
|
// @Summary User Login
|
|
// @Tags Authentication
|
|
// @Accept x-www-form-urlencoded
|
|
// @Accept application/json
|
|
// @Param payload body LoginForm true "Login Data"
|
|
// @Param provider query string false "auth provider"
|
|
// @Produce json
|
|
// @Success 200 {object} TokenResponse
|
|
// @Router /v1/users/login [POST]
|
|
func (ctrl *V1Controller) HandleAuthLogin(ps ...AuthProvider) errchain.HandlerFunc {
|
|
if len(ps) == 0 {
|
|
panic("no auth providers provided")
|
|
}
|
|
|
|
providers := make(map[string]AuthProvider)
|
|
for _, p := range ps {
|
|
log.Info().Str("name", p.Name()).Msg("registering auth provider")
|
|
providers[p.Name()] = p
|
|
}
|
|
|
|
return func(w http.ResponseWriter, r *http.Request) error {
|
|
// Extract provider query
|
|
provider := r.URL.Query().Get("provider")
|
|
if provider == "" {
|
|
provider = "local"
|
|
}
|
|
|
|
// Block local only when disabled
|
|
if provider == "local" && !ctrl.config.Options.AllowLocalLogin {
|
|
return validate.NewRequestError(fmt.Errorf("local login is not enabled"), http.StatusForbidden)
|
|
}
|
|
|
|
// Get the provider
|
|
p, ok := providers[provider]
|
|
if !ok {
|
|
return validate.NewRequestError(errors.New("invalid auth provider"), http.StatusBadRequest)
|
|
}
|
|
|
|
newToken, err := p.Authenticate(w, r)
|
|
if err != nil {
|
|
log.Warn().Err(err).Msg("authentication failed")
|
|
return validate.NewUnauthorizedError()
|
|
}
|
|
|
|
ctrl.setCookies(w, noPort(r.Host), newToken.Raw, newToken.ExpiresAt, true)
|
|
return server.JSON(w, http.StatusOK, TokenResponse{
|
|
Token: "Bearer " + newToken.Raw,
|
|
ExpiresAt: newToken.ExpiresAt,
|
|
AttachmentToken: newToken.AttachmentToken,
|
|
})
|
|
}
|
|
}
|
|
|
|
// HandleAuthLogout godoc
|
|
//
|
|
// @Summary User Logout
|
|
// @Tags Authentication
|
|
// @Success 204
|
|
// @Router /v1/users/logout [POST]
|
|
// @Security Bearer
|
|
func (ctrl *V1Controller) HandleAuthLogout() errchain.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) error {
|
|
token := services.UseTokenCtx(r.Context())
|
|
if token == "" {
|
|
return validate.NewRequestError(errors.New("no token within request context"), http.StatusUnauthorized)
|
|
}
|
|
|
|
err := ctrl.svc.User.Logout(r.Context(), token)
|
|
if err != nil {
|
|
return validate.NewRequestError(err, http.StatusInternalServerError)
|
|
}
|
|
|
|
ctrl.unsetCookies(w, noPort(r.Host))
|
|
return server.JSON(w, http.StatusNoContent, nil)
|
|
}
|
|
}
|
|
|
|
// HandleAuthRefresh godoc
|
|
//
|
|
// @Summary User Token Refresh
|
|
// @Description handleAuthRefresh returns a handler that will issue a new token from an existing token.
|
|
// @Description This does not validate that the user still exists within the database.
|
|
// @Tags Authentication
|
|
// @Success 200
|
|
// @Router /v1/users/refresh [GET]
|
|
// @Security Bearer
|
|
func (ctrl *V1Controller) HandleAuthRefresh() errchain.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) error {
|
|
requestToken := services.UseTokenCtx(r.Context())
|
|
if requestToken == "" {
|
|
return validate.NewRequestError(errors.New("no token within request context"), http.StatusUnauthorized)
|
|
}
|
|
|
|
newToken, err := ctrl.svc.User.RenewToken(r.Context(), requestToken)
|
|
if err != nil {
|
|
return validate.NewUnauthorizedError()
|
|
}
|
|
|
|
ctrl.setCookies(w, noPort(r.Host), newToken.Raw, newToken.ExpiresAt, false)
|
|
return server.JSON(w, http.StatusOK, newToken)
|
|
}
|
|
}
|
|
|
|
func noPort(host string) string {
|
|
return strings.Split(host, ":")[0]
|
|
}
|
|
|
|
func (ctrl *V1Controller) setCookies(w http.ResponseWriter, domain, token string, expires time.Time, remember bool) {
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameRemember,
|
|
Value: strconv.FormatBool(remember),
|
|
Expires: expires,
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: true,
|
|
Path: "/",
|
|
})
|
|
|
|
// Set HTTP only cookie
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameToken,
|
|
Value: token,
|
|
Expires: expires,
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: true,
|
|
Path: "/",
|
|
})
|
|
|
|
// Set Fake Session cookie
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameSession,
|
|
Value: "true",
|
|
Expires: expires,
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: false,
|
|
Path: "/",
|
|
})
|
|
}
|
|
|
|
func (ctrl *V1Controller) unsetCookies(w http.ResponseWriter, domain string) {
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameToken,
|
|
Value: "",
|
|
Expires: time.Unix(0, 0),
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: true,
|
|
Path: "/",
|
|
})
|
|
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameRemember,
|
|
Value: "false",
|
|
Expires: time.Unix(0, 0),
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: true,
|
|
Path: "/",
|
|
})
|
|
|
|
// Set Fake Session cookie
|
|
http.SetCookie(w, &http.Cookie{
|
|
Name: cookieNameSession,
|
|
Value: "false",
|
|
Expires: time.Unix(0, 0),
|
|
Domain: domain,
|
|
Secure: ctrl.cookieSecure,
|
|
HttpOnly: false,
|
|
Path: "/",
|
|
})
|
|
}
|
|
|
|
// HandleOIDCLogin godoc
|
|
//
|
|
// @Summary OIDC Login Initiation
|
|
// @Tags Authentication
|
|
// @Produce json
|
|
// @Success 302
|
|
// @Router /v1/users/login/oidc [GET]
|
|
func (ctrl *V1Controller) HandleOIDCLogin() errchain.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) error {
|
|
// Forbidden if OIDC is not enabled
|
|
if !ctrl.config.OIDC.Enabled {
|
|
return validate.NewRequestError(fmt.Errorf("OIDC is not enabled"), http.StatusForbidden)
|
|
}
|
|
|
|
// Check if OIDC provider is available
|
|
if ctrl.oidcProvider == nil {
|
|
log.Error().Msg("OIDC provider not initialized")
|
|
return validate.NewRequestError(errors.New("OIDC provider not available"), http.StatusInternalServerError)
|
|
}
|
|
|
|
// Initiate OIDC flow
|
|
_, err := ctrl.oidcProvider.InitiateOIDCFlow(w, r)
|
|
return err
|
|
}
|
|
}
|
|
|
|
// HandleOIDCCallback godoc
|
|
//
|
|
// @Summary OIDC Callback Handler
|
|
// @Tags Authentication
|
|
// @Param code query string true "Authorization code"
|
|
// @Param state query string true "State parameter"
|
|
// @Success 302
|
|
// @Router /v1/users/login/oidc/callback [GET]
|
|
func (ctrl *V1Controller) HandleOIDCCallback() errchain.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) error {
|
|
// Forbidden if OIDC is not enabled
|
|
if !ctrl.config.OIDC.Enabled {
|
|
return validate.NewRequestError(fmt.Errorf("OIDC is not enabled"), http.StatusForbidden)
|
|
}
|
|
|
|
// Check if OIDC provider is available
|
|
if ctrl.oidcProvider == nil {
|
|
log.Error().Msg("OIDC provider not initialized")
|
|
return validate.NewRequestError(errors.New("OIDC provider not available"), http.StatusInternalServerError)
|
|
}
|
|
|
|
// Handle callback
|
|
newToken, err := ctrl.oidcProvider.HandleCallback(w, r)
|
|
if err != nil {
|
|
log.Err(err).Msg("OIDC callback failed")
|
|
http.Redirect(w, r, "/?oidc_error=oidc_auth_failed", http.StatusFound)
|
|
return nil
|
|
}
|
|
|
|
// Set cookies and redirect to home
|
|
ctrl.setCookies(w, noPort(r.Host), newToken.Raw, newToken.ExpiresAt, true)
|
|
http.Redirect(w, r, "/home", http.StatusFound)
|
|
return nil
|
|
}
|
|
}
|