From f2770584c780c3f5191dd2b85759066f21ad369d Mon Sep 17 00:00:00 2001 From: Matt Kilgore Date: Sun, 16 Mar 2025 12:25:09 -0400 Subject: [PATCH] chore: Always use LTS NodeJS for Docker builds (#589) * chore: Always use LTS NodeJS for Docker builds * chore: Update devcontainers too --- .devcontainer/Dockerfile | 2 +- Dockerfile | 4 ++-- Dockerfile.rootless | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 9809bfd8..27c8b8fc 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,3 +1,3 @@ -FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:18-bullseye +FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:22-bullseye RUN sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b ~/.local/bin diff --git a/Dockerfile b/Dockerfile index e2b0d868..d8247d32 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # Node dependencies stage -FROM public.ecr.aws/docker/library/node:18-alpine AS frontend-dependencies +FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-dependencies WORKDIR /app # Install pnpm globally (caching layer) @@ -10,7 +10,7 @@ COPY frontend/package.json frontend/pnpm-lock.yaml ./ RUN pnpm install --frozen-lockfile --shamefully-hoist # Build Nuxt (frontend) stage -FROM public.ecr.aws/docker/library/node:18-alpine AS frontend-builder +FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder WORKDIR /app # Install pnpm globally again (it can reuse the cache if not changed) diff --git a/Dockerfile.rootless b/Dockerfile.rootless index 0f8a1064..82f46364 100644 --- a/Dockerfile.rootless +++ b/Dockerfile.rootless @@ -1,5 +1,5 @@ # Node dependencies stage -FROM public.ecr.aws/docker/library/node:18-alpine AS frontend-dependencies +FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-dependencies WORKDIR /app # Install pnpm globally (caching layer) @@ -10,7 +10,7 @@ COPY frontend/package.json frontend/pnpm-lock.yaml ./ RUN pnpm install --frozen-lockfile --shamefully-hoist # Build Nuxt (frontend) stage -FROM public.ecr.aws/docker/library/node:18-alpine AS frontend-builder +FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder WORKDIR /app # Install pnpm globally again (it can reuse the cache if not changed)