diff --git a/backend/internal/core/services/service_items_attachments_test.go b/backend/internal/core/services/service_items_attachments_test.go index 8fb5d155..1b7cb416 100644 --- a/backend/internal/core/services/service_items_attachments_test.go +++ b/backend/internal/core/services/service_items_attachments_test.go @@ -107,7 +107,7 @@ func TestItemService_AddAttachment_InvalidStorage(t *testing.T) { // Attempt to add attachment with invalid storage - should return an error _, err = svc.AttachmentAdd(tCtx, itm.ID, "testfile.txt", "attachment", false, reader) - + // This should return an error now (after the fix) assert.Error(t, err, "AttachmentAdd should return an error when storage is invalid") } diff --git a/backend/internal/data/repo/repo_items_search_test.go b/backend/internal/data/repo/repo_items_search_test.go index cb7accf3..e2156815 100644 --- a/backend/internal/data/repo/repo_items_search_test.go +++ b/backend/internal/data/repo/repo_items_search_test.go @@ -3,18 +3,18 @@ package repo import ( "testing" - "github.com/sysadminsmedia/homebox/backend/pkgs/textutils" "github.com/stretchr/testify/assert" + "github.com/sysadminsmedia/homebox/backend/pkgs/textutils" ) func TestItemsRepository_AccentInsensitiveSearch(t *testing.T) { // Test cases for accent-insensitive search testCases := []struct { - name string - itemName string - searchQuery string - shouldMatch bool - description string + name string + itemName string + searchQuery string + shouldMatch bool + description string }{ { name: "Spanish accented item, search without accents", @@ -155,25 +155,25 @@ func TestItemsRepository_AccentInsensitiveSearch(t *testing.T) { t.Run(tc.name, func(t *testing.T) { // Test the normalization logic used in the repository normalizedSearch := textutils.NormalizeSearchQuery(tc.searchQuery) - + // This simulates what happens in the repository // The original search would find exact matches (case-insensitive) // The normalized search would find accent-insensitive matches - + // Test that our normalization works as expected if tc.shouldMatch { // If it should match, then either the original query should match // or the normalized query should match when applied to the stored data assert.NotEqual(t, "", normalizedSearch, "Normalized search should not be empty") - + // The key insight is that we're searching with both the original and normalized queries // So "electrónica" will be found when searching for "electronica" because: // 1. Original search: "electronica" doesn't match "electrónica" // 2. Normalized search: "electronica" matches the normalized version - t.Logf("✓ %s: Item '%s' should be found with search '%s' (normalized: '%s')", + t.Logf("✓ %s: Item '%s' should be found with search '%s' (normalized: '%s')", tc.description, tc.itemName, tc.searchQuery, normalizedSearch) } else { - t.Logf("✗ %s: Item '%s' should NOT be found with search '%s' (normalized: '%s')", + t.Logf("✗ %s: Item '%s' should NOT be found with search '%s' (normalized: '%s')", tc.description, tc.itemName, tc.searchQuery, normalizedSearch) } })