From bc7ca76ab5278cc7958a9ee2e5f98fdf14f0f4fc Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 14 Dec 2025 02:19:19 +0000 Subject: [PATCH] Fix code review issues: migration comments and add missing translations Co-authored-by: tankerkiller125 <3457368+tankerkiller125@users.noreply.github.com> --- .../postgres/20251214000000_add_label_parent_child.sql | 2 +- .../sqlite3/20251214000000_add_label_parent_child.sql | 2 +- frontend/locales/en.json | 7 +++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/backend/internal/data/migrations/postgres/20251214000000_add_label_parent_child.sql b/backend/internal/data/migrations/postgres/20251214000000_add_label_parent_child.sql index 01f711ad..899698e7 100644 --- a/backend/internal/data/migrations/postgres/20251214000000_add_label_parent_child.sql +++ b/backend/internal/data/migrations/postgres/20251214000000_add_label_parent_child.sql @@ -1,3 +1,3 @@ -- +goose Up --- Add parent_id column to labels table for hierarchical label organization +-- Add label_children column to labels table for hierarchical label organization ALTER TABLE labels ADD COLUMN label_children UUID REFERENCES labels(id) ON DELETE CASCADE; diff --git a/backend/internal/data/migrations/sqlite3/20251214000000_add_label_parent_child.sql b/backend/internal/data/migrations/sqlite3/20251214000000_add_label_parent_child.sql index 10f99336..ae7c927f 100644 --- a/backend/internal/data/migrations/sqlite3/20251214000000_add_label_parent_child.sql +++ b/backend/internal/data/migrations/sqlite3/20251214000000_add_label_parent_child.sql @@ -1,3 +1,3 @@ -- +goose Up --- Add parent_id column to labels table for hierarchical label organization +-- Add label_children column to labels table for hierarchical label organization ALTER TABLE labels ADD COLUMN label_children TEXT REFERENCES labels(id) ON DELETE CASCADE; diff --git a/frontend/locales/en.json b/frontend/locales/en.json index 394b251c..d406f767 100644 --- a/frontend/locales/en.json +++ b/frontend/locales/en.json @@ -202,6 +202,11 @@ "label_name_too_long": "Label name must not be longer than 50 characters" } }, + "parent_selector": { + "label": "Parent Label", + "no_parent": "No Parent", + "placeholder": "Select a parent label" + }, "selector": { "select_labels": "Select Labels" } @@ -506,8 +511,10 @@ "warranty_expires": "Warranty Expires" }, "labels": { + "child_labels": "Child Labels", "label_delete_confirm": "Are you sure you want to delete this label? This action cannot be undone.", "no_results": "No Labels Found", + "parent_label": "Parent Label", "toast": { "failed_delete_label": "Failed to delete label", "failed_load_label": "Failed to load label",