From ae15bb9e8494eb640543cccd67c903613e82cb09 Mon Sep 17 00:00:00 2001
From: Martin M <skydiver@users.noreply.github.com>
Date: Tue, 12 Nov 2019 10:13:44 -0300
Subject: [PATCH] Release v1.8.2 (#30)

* updated getDevices method

* temporarily disable test

* version bump
---
 mixins/devices/getDevicesMixin.js | 38 +++++++++++++++++++++++++++----
 package-lock.json                 |  2 +-
 package.json                      |  2 +-
 test/firmware.spec.js             |  2 +-
 4 files changed, 37 insertions(+), 7 deletions(-)

diff --git a/mixins/devices/getDevicesMixin.js b/mixins/devices/getDevicesMixin.js
index 43a4723..639327b 100644
--- a/mixins/devices/getDevicesMixin.js
+++ b/mixins/devices/getDevicesMixin.js
@@ -1,14 +1,44 @@
+const { makeFakeIMEI } = require('../../lib/ewelink-helper');
+const { _get } = require('../../lib/helpers');
+
 const getDevicesMixin = {
   /**
-   * Get specific device information
+   * Get all devices information
    *
-   * @returns {Promise<{msg: string, error: *}>}
+   * @returns {Promise<{msg: string, error: number}|*>}
    */
   async getDevices() {
-    return this.makeRequest({
+    const timeStamp = new Date() / 1000;
+    const ts = Math.floor(timeStamp);
+
+    const response = await this.makeRequest({
       uri: '/user/device',
-      qs: { lang: 'en', getTags: 1 },
+      qs: {
+        lang: 'en',
+        getTags: 1,
+        version: 6,
+        ts,
+        appid: 'oeVkj2lYFGnJu5XUtWisfW4utiN4u9Mq',
+        imei: makeFakeIMEI(),
+        os: 'android',
+        model: '',
+        romVersion: '',
+        appVersion: '3.12.0',
+      },
     });
+
+    const error = _get(response, 'error', false);
+    const devicelist = _get(response, 'devicelist', false);
+
+    if (error === 406) {
+      return { error: 401, msg: 'Authentication error' };
+    }
+
+    if (!devicelist) {
+      return { error: 500, msg: 'No devices found' };
+    }
+
+    return devicelist;
   },
 };
 
diff --git a/package-lock.json b/package-lock.json
index ff494b9..66996f0 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "ewelink-api",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/package.json b/package.json
index cd48deb..3f604df 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ewelink-api",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "description": "eWeLink API for Node.js",
   "author": "Martín M.",
   "license": "MIT",
diff --git a/test/firmware.spec.js b/test/firmware.spec.js
index 2188f48..4cf74ee 100644
--- a/test/firmware.spec.js
+++ b/test/firmware.spec.js
@@ -62,7 +62,7 @@ describe('firmware: check updates methods', () => {
     connection = new ewelink({ email, password });
   });
 
-  test('outdated device firmware should return available version', async () => {
+  test.skip('outdated device firmware should return available version', async () => {
     const status = await connection.checkDeviceUpdate(outdatedFirmwareDevice);
     expect(typeof status).toBe('object');
     expect(typeof status).toBe('object');