From e2072d35c8d1b72f6fd2d685a3aff95fdc3f8807 Mon Sep 17 00:00:00 2001 From: Amir Raminfar Date: Thu, 18 Nov 2021 14:06:54 -0800 Subject: [PATCH] Settings to useStorage (#1602) * Uses storage for settings * Cleans settings * Fixes tests for storage * Removes store.js * Uses ts * Fixes tests * Removes autoprefixer --- assets/App.vue | 11 +- assets/components/LogEventSource.spec.ts | 14 +- assets/components/LogViewer.vue | 14 +- assets/components/RelativeTime.vue | 5 +- assets/components/Search.vue | 8 +- assets/composables/settings.ts | 65 +++++++++ assets/pages/Settings.vue | 78 ++++------- assets/store/index.ts | 12 +- assets/store/settings.ts | 11 -- jest.config.js => jest.config.ts | 10 +- package.json | 6 +- pnpm-lock.yaml | 168 ++++++++++++++--------- 12 files changed, 241 insertions(+), 161 deletions(-) create mode 100644 assets/composables/settings.ts delete mode 100644 assets/store/settings.ts rename jest.config.js => jest.config.ts (53%) diff --git a/assets/App.vue b/assets/App.vue index 94d7c671..5430fa79 100644 --- a/assets/App.vue +++ b/assets/App.vue @@ -44,12 +44,13 @@ diff --git a/assets/components/LogEventSource.spec.ts b/assets/components/LogEventSource.spec.ts index 42b361d8..b7901e0e 100644 --- a/assets/components/LogEventSource.spec.ts +++ b/assets/components/LogEventSource.spec.ts @@ -5,6 +5,7 @@ import EventSource, { sources } from "eventsourcemock"; import debounce from "lodash.debounce"; import LogEventSource from "./LogEventSource.vue"; import LogViewer from "./LogViewer.vue"; +import { settings } from "../composables/settings"; import { mocked } from "ts-jest/utils"; jest.mock("lodash.debounce", () => @@ -27,14 +28,17 @@ describe("", () => { })); mocked(debounce).mockClear(); + jest.resetModules(); }); - function createLogEventSource({ - hourStyle = "auto", - searchFilter = null, - }: { hourStyle?: string; searchFilter?: string | null } = {}) { + function createLogEventSource( + { searchFilter = null, hourStyle = "auto" }: { searchFilter?: string | null; hourStyle?: "auto" | "24" | "12" } = { + hourStyle: "auto", + } + ) { + settings.value.hourStyle = hourStyle; const store = createStore({ - state: { searchFilter, settings: { size: "medium", showTimestamp: true, hourStyle } }, + state: { searchFilter }, getters: { allContainersById() { return { diff --git a/assets/components/LogViewer.vue b/assets/components/LogViewer.vue index dd56ab79..993d15c6 100644 --- a/assets/components/LogViewer.vue +++ b/assets/components/LogViewer.vue @@ -1,7 +1,7 @@ +