From 9db559c9cef74015a2846b3526fe6ccbe4d8b07a Mon Sep 17 00:00:00 2001
From: Amir Raminfar <findamir@gmail.com>
Date: Fri, 6 Jun 2025 09:28:57 -0700
Subject: [PATCH] chore: refactors code by moving loader to a log entry (#3951)

---
 assets/components.d.ts                        |  1 +
 assets/components/InfiniteLoader.vue          | 31 ---------------
 assets/components/LogViewer/EventSource.vue   | 15 +------
 .../components/LogViewer/LoadMoreLogItem.vue  | 29 ++++++++++++++
 assets/components/LogViewer/LogList.vue       |  6 +--
 .../__snapshots__/EventSource.spec.ts.snap    | 23 +++++++----
 assets/composable/eventStreams.ts             | 39 ++++++++++++-------
 assets/composable/scrollContext.ts            |  9 ++---
 assets/models/LogEntry.ts                     | 18 +++++++++
 9 files changed, 94 insertions(+), 77 deletions(-)
 delete mode 100644 assets/components/InfiniteLoader.vue
 create mode 100644 assets/components/LogViewer/LoadMoreLogItem.vue

diff --git a/assets/components.d.ts b/assets/components.d.ts
index 88534a5f..0f65c18b 100644
--- a/assets/components.d.ts
+++ b/assets/components.d.ts
@@ -53,6 +53,7 @@ declare module 'vue' {
     KeyShortcut: typeof import('./components/common/KeyShortcut.vue')['default']
     LabeledInput: typeof import('./components/common/LabeledInput.vue')['default']
     Links: typeof import('./components/Links.vue')['default']
+    LoadMoreLogItem: typeof import('./components/LogViewer/LoadMoreLogItem.vue')['default']
     LogAnalytics: typeof import('./components/LogViewer/LogAnalytics.vue')['default']
     LogDate: typeof import('./components/LogViewer/LogDate.vue')['default']
     LogDetails: typeof import('./components/LogViewer/LogDetails.vue')['default']
diff --git a/assets/components/InfiniteLoader.vue b/assets/components/InfiniteLoader.vue
deleted file mode 100644
index a5684a57..00000000
--- a/assets/components/InfiniteLoader.vue
+++ /dev/null
@@ -1,31 +0,0 @@
-<template>
-  <div ref="root" class="flex min-h-[1px] justify-center">
-    <span class="loading loading-bars loading-md text-primary mt-4" v-show="isLoading"></span>
-  </div>
-</template>
-
-<script lang="ts" setup>
-const { onLoadMore = () => Promise.resolve(), enabled } = defineProps<{
-  onLoadMore: () => Promise<void>;
-  enabled: boolean;
-}>();
-
-const isLoading = ref(false);
-const root = ref<HTMLElement>();
-
-const observer = new IntersectionObserver(async (entries) => {
-  if (entries[0].intersectionRatio <= 0) return;
-  if (onLoadMore && enabled) {
-    const scrollingParent = root.value?.closest("[data-scrolling]") || document.documentElement;
-    const previousHeight = scrollingParent.scrollHeight;
-    isLoading.value = true;
-    await onLoadMore();
-    isLoading.value = false;
-    await nextTick();
-    scrollingParent.scrollTop += scrollingParent.scrollHeight - previousHeight;
-  }
-});
-
-onMounted(() => observer.observe(root.value!));
-onUnmounted(() => observer.disconnect());
-</script>
diff --git a/assets/components/LogViewer/EventSource.vue b/assets/components/LogViewer/EventSource.vue
index d451293f..b6ba25fd 100644
--- a/assets/components/LogViewer/EventSource.vue
+++ b/assets/components/LogViewer/EventSource.vue
@@ -1,5 +1,4 @@
 <template>
-  <InfiniteLoader :onLoadMore="fetchMore" :enabled="!loadingMore && messages.length > 10" />
   <ul class="flex animate-pulse flex-col gap-4 p-4" v-if="loading || (noLogs && waitingForMoreLog)">
     <div class="flex flex-row gap-2" v-for="size in sizes">
       <div class="bg-base-content/50 h-3 w-40 shrink-0 rounded-full opacity-50"></div>
@@ -22,10 +21,8 @@ const { entity, streamSource } = $defineProps<{
   entity: T;
 }>();
 
-const { messages, loadOlderLogs, isLoadingMore, opened, loading, error, eventSourceURL } = streamSource(
-  toRef(() => entity),
-);
-const { loadingMore } = useLoggingContext();
+const { messages, opened, loading, error, eventSourceURL } = streamSource(toRef(() => entity));
+
 const color = computed(() => {
   if (error.value) return "error";
   if (loading.value) return "secondary";
@@ -41,14 +38,6 @@ defineExpose({
   clear: () => (messages.value = []),
 });
 
-const fetchMore = async () => {
-  if (!isLoadingMore.value) {
-    loadingMore.value = true;
-    await loadOlderLogs();
-    loadingMore.value = false;
-  }
-};
-
 const sizes = computedWithControl(eventSourceURL, () => {
   const sizeOptions = [
     "w-2/12",
diff --git a/assets/components/LogViewer/LoadMoreLogItem.vue b/assets/components/LogViewer/LoadMoreLogItem.vue
new file mode 100644
index 00000000..a4d4656b
--- /dev/null
+++ b/assets/components/LogViewer/LoadMoreLogItem.vue
@@ -0,0 +1,29 @@
+<template>
+  <div ref="root" class="flex min-h-[1px] flex-1 content-center justify-center p-2">
+    <span class="loading loading-bars loading-md text-primary" v-show="isLoading"></span>
+  </div>
+</template>
+<script lang="ts" setup>
+import { LoadMoreLogEntry } from "@/models/LogEntry";
+
+const { logEntry } = defineProps<{
+  logEntry: LoadMoreLogEntry;
+}>();
+
+const isLoading = ref(false);
+const root = ref<HTMLElement>();
+
+useIntersectionObserver(root, async (entries) => {
+  if (entries[0].intersectionRatio <= 0) return;
+  if (isLoading.value) return;
+  const scrollingParent = root.value?.closest("[data-scrolling]") || document.documentElement;
+  const previousHeight = scrollingParent.scrollHeight;
+  isLoading.value = true;
+  await logEntry.loadMore();
+  isLoading.value = false;
+  await nextTick();
+  scrollingParent.scrollTop += scrollingParent.scrollHeight - previousHeight;
+});
+</script>
+
+<style scoped></style>
diff --git a/assets/components/LogViewer/LogList.vue b/assets/components/LogViewer/LogList.vue
index f9e6cd70..d3bc42f1 100644
--- a/assets/components/LogViewer/LogList.vue
+++ b/assets/components/LogViewer/LogList.vue
@@ -16,16 +16,12 @@
 <script lang="ts" setup>
 import { type JSONObject, LogEntry } from "@/models/LogEntry";
 
-const { loading, progress, currentDate } = useScrollContext();
+const { progress, currentDate } = useScrollContext();
 
 const { messages } = defineProps<{
   messages: LogEntry<string | JSONObject>[];
 }>();
 
-watchEffect(() => {
-  loading.value = messages.length === 0;
-});
-
 const { containers } = useLoggingContext();
 
 const list = ref<HTMLElement[]>([]);
diff --git a/assets/components/LogViewer/__snapshots__/EventSource.spec.ts.snap b/assets/components/LogViewer/__snapshots__/EventSource.spec.ts.snap
index ffc41b5b..8c917b8e 100644
--- a/assets/components/LogViewer/__snapshots__/EventSource.spec.ts.snap
+++ b/assets/components/LogViewer/__snapshots__/EventSource.spec.ts.snap
@@ -2,6 +2,9 @@
 
 exports[`<ContainerEventSource /> > render html correctly > should render dates with 12 hour style 1`] = `
 "<ul data-v-cf9ff940="" class="group pt-4 medium" data-logs="" show-container-name="false">
+  <li data-v-cf9ff940="" data-key="1560336942709" data-time="1560336942709" class="group/entry">
+    <div data-v-cf9ff940="" class="flex min-h-[1px] flex-1 content-center justify-center p-2"><span class="loading loading-bars loading-md text-primary" style="display: none;"></span></div>
+  </li>
   <li data-v-cf9ff940="" data-key="1" data-time="1560336942459" class="group/entry">
     <div data-v-cf9ff940="" class="relative flex w-full items-start gap-x-2 group-[.compact]:items-stretch">
       <!--v-if-->
@@ -24,6 +27,9 @@ exports[`<ContainerEventSource /> > render html correctly > should render dates
 
 exports[`<ContainerEventSource /> > render html correctly > should render dates with 24 hour style 1`] = `
 "<ul data-v-cf9ff940="" class="group pt-4 medium" data-logs="" show-container-name="false">
+  <li data-v-cf9ff940="" data-key="1560336942709" data-time="1560336942709" class="group/entry">
+    <div data-v-cf9ff940="" class="flex min-h-[1px] flex-1 content-center justify-center p-2"><span class="loading loading-bars loading-md text-primary" style="display: none;"></span></div>
+  </li>
   <li data-v-cf9ff940="" data-key="1" data-time="1560336942459" class="group/entry">
     <div data-v-cf9ff940="" class="relative flex w-full items-start gap-x-2 group-[.compact]:items-stretch">
       <!--v-if-->
@@ -46,6 +52,9 @@ exports[`<ContainerEventSource /> > render html correctly > should render dates
 
 exports[`<ContainerEventSource /> > render html correctly > should render messages 1`] = `
 "<ul data-v-cf9ff940="" class="group pt-4 medium" data-logs="" show-container-name="false">
+  <li data-v-cf9ff940="" data-key="1560336942709" data-time="1560336942709" class="group/entry">
+    <div data-v-cf9ff940="" class="flex min-h-[1px] flex-1 content-center justify-center p-2"><span class="loading loading-bars loading-md text-primary" style="display: none;"></span></div>
+  </li>
   <li data-v-cf9ff940="" data-key="1" data-time="1560336942459" class="group/entry">
     <div data-v-cf9ff940="" class="relative flex w-full items-start gap-x-2 group-[.compact]:items-stretch">
       <!--v-if-->
@@ -67,14 +76,14 @@ exports[`<ContainerEventSource /> > render html correctly > should render messag
 `;
 
 exports[`<ContainerEventSource /> > should parse messages 1`] = `
-SimpleLogEntry {
-  "_message": "This is a message.",
-  "containerID": undefined,
-  "date": 2019-06-12T10:55:42.459Z,
-  "id": 1,
+LoadMoreLogEntry {
+  "_message": "",
+  "containerID": "",
+  "date": 2019-06-12T10:55:42.709Z,
+  "id": 1560336942709,
   "level": undefined,
-  "position": undefined,
-  "rawMessage": "This is a message.",
+  "loader": [Function],
+  "rawMessage": "info",
   "std": "stderr",
 }
 `;
diff --git a/assets/composable/eventStreams.ts b/assets/composable/eventStreams.ts
index f6ddf077..3503016f 100644
--- a/assets/composable/eventStreams.ts
+++ b/assets/composable/eventStreams.ts
@@ -9,6 +9,7 @@ import {
   ContainerEventLogEntry,
   ComplexLogEntry,
   SkippedLogsEntry,
+  LoadMoreLogEntry,
 } from "@/models/LogEntry";
 import { Service, Stack } from "@/models/Stack";
 import { Container, GroupedContainers } from "@/models/Container";
@@ -60,6 +61,8 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
   const loading = ref(true);
   const error = ref(false);
   const { paused: scrollingPaused } = useScrollContext();
+  const { streamConfig, hasComplexLogs, levels, loadingMore } = useLoggingContext();
+  let initial = true;
 
   function flushNow() {
     if (messages.value.length + buffer.value.length > config.maxLogs) {
@@ -86,9 +89,15 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
         buffer.value = [];
       }
     } else {
-      if (messages.value.length == 0) {
+      if (initial) {
         // sort the buffer the very first time because of multiple logs in parallel
         buffer.value.sort((a, b) => a.date.getTime() - b.date.getTime());
+
+        if (loadMoreUrl) {
+          const loadMoreItem = new LoadMoreLogEntry(new Date(), loadOlderLogs);
+          messages.value = [loadMoreItem];
+        }
+        initial = false;
       }
       messages.value = [...messages.value, ...buffer.value];
       buffer.value = [];
@@ -110,8 +119,6 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
     buffer.value = [];
   }
 
-  const { streamConfig, hasComplexLogs, levels } = useLoggingContext();
-
   const params = computed(() => {
     const params = new URLSearchParams();
     if (streamConfig.value.stdout) params.append("stdout", "1");
@@ -131,6 +138,7 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
     opened.value = false;
     loading.value = true;
     error.value = false;
+    initial = true;
     es = new EventSource(urlWithParams.value);
     es.addEventListener("container-event", (e) => {
       const event = JSON.parse((e as MessageEvent).data) as {
@@ -174,14 +182,13 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
 
   watch(urlWithParams, () => connect(), { immediate: true });
 
-  const isLoadingMore = ref(false);
-
   async function loadBetween(from: Date, to: Date, lastSeenId: number, minimum: number = 0) {
+    if (!loadMoreUrl) throw new Error("No loadMoreUrl");
     const abortController = new AbortController();
     const signal = abortController.signal;
-    if (isLoadingMore.value) throw new Error("Already loading");
+    if (loadingMore.value) throw new Error("Already loading");
     try {
-      isLoadingMore.value = true;
+      loadingMore.value = true;
       const urlWithMoreParams = computed(() => {
         const loadMoreParams = new URLSearchParams(params.value);
         loadMoreParams.append("from", from.toISOString());
@@ -204,21 +211,24 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
         signal,
       };
     } finally {
-      isLoadingMore.value = false;
+      loadingMore.value = false;
     }
   }
 
-  async function loadOlderLogs() {
+  async function loadOlderLogs(entry: LoadMoreLogEntry) {
     if (!loadMoreUrl) throw new Error("No loadMoreUrl");
-    const to = messages.value[0].date;
-    const lastSeenId = messages.value[0].id;
+    if (!(messages.value[0] instanceof LoadMoreLogEntry)) throw new Error("No loadMoreLogEntry on first item");
+
+    const [loader, ...existingLogs] = messages.value;
+    const to = existingLogs[0].date;
+    const lastSeenId = existingLogs[0].id;
     const last = messages.value[Math.min(messages.value.length - 1, 300)].date;
     const delta = to.getTime() - last.getTime();
     const from = new Date(to.getTime() + delta);
     try {
-      const { logs, signal } = await loadBetween(from, to, lastSeenId, 100);
-      if (logs && signal.aborted === false) {
-        messages.value = [...logs, ...messages.value];
+      const { logs: newLogs, signal } = await loadBetween(from, to, lastSeenId, 100);
+      if (newLogs && signal.aborted === false) {
+        messages.value = [loader, ...newLogs, ...existingLogs];
       }
     } catch (error) {
       console.error(error);
@@ -251,7 +261,6 @@ function useLogStream(url: Ref<string>, loadMoreUrl?: Ref<string>) {
   return {
     messages,
     loadOlderLogs,
-    isLoadingMore,
     hasComplexLogs,
     opened,
     error,
diff --git a/assets/composable/scrollContext.ts b/assets/composable/scrollContext.ts
index ef5efab2..050d8f8e 100644
--- a/assets/composable/scrollContext.ts
+++ b/assets/composable/scrollContext.ts
@@ -1,5 +1,4 @@
 type ScrollContext = {
-  loading: boolean;
   paused: boolean;
   progress: number;
   currentDate: Date;
@@ -9,20 +8,18 @@ type ScrollContext = {
 export const scrollContextKey = Symbol("scrollContext") as InjectionKey<ScrollContext>;
 
 export const provideScrollContext = () => {
-  const context = defauleValue();
+  const context = defaultValue();
   provide(scrollContextKey, context);
   return context;
 };
 
 export const useScrollContext = () => {
-  const defaultValue = defauleValue();
-  const context = inject(scrollContextKey, defaultValue);
+  const context = inject(scrollContextKey, defaultValue());
   return toRefs(context);
 };
 
-function defauleValue() {
+function defaultValue() {
   return reactive({
-    loading: false,
     paused: false,
     progress: 1,
     currentDate: new Date(),
diff --git a/assets/models/LogEntry.ts b/assets/models/LogEntry.ts
index 7f50a7aa..1b91e919 100644
--- a/assets/models/LogEntry.ts
+++ b/assets/models/LogEntry.ts
@@ -4,6 +4,7 @@ import ComplexLogItem from "@/components/LogViewer/ComplexLogItem.vue";
 import SimpleLogItem from "@/components/LogViewer/SimpleLogItem.vue";
 import ContainerEventLogItem from "@/components/LogViewer/ContainerEventLogItem.vue";
 import SkippedEntriesLogItem from "@/components/LogViewer/SkippedEntriesLogItem.vue";
+import LoadMoreLogItem from "@/components/LogViewer/LoadMoreLogItem.vue";
 
 export type JSONValue = string | number | boolean | JSONObject | Array<JSONValue>;
 export type JSONObject = { [x: string]: JSONValue };
@@ -188,6 +189,23 @@ export class SkippedLogsEntry extends LogEntry<string> {
   }
 }
 
+export class LoadMoreLogEntry extends LogEntry<string> {
+  constructor(
+    date: Date,
+    private readonly loader: (i: LoadMoreLogEntry) => Promise<void>,
+  ) {
+    super("", "", date.getTime(), date, "stderr", "info");
+  }
+
+  getComponent(): Component {
+    return LoadMoreLogItem;
+  }
+
+  async loadMore(): Promise<void> {
+    await this.loader(this);
+  }
+}
+
 export function asLogEntry(event: LogEvent): LogEntry<string | JSONObject> {
   if (isObject(event.m)) {
     return new ComplexLogEntry(