Release 3.7.7 - See CHANGELOG.md

Merge pull request #210 from codemonium/simplify-pg_isready
Simplify pg_isready usage
2025-12-22 21:53:42 +01:00 · 2023-03-20 16:24:23 -07:00 · 2023-03-20 16:22:13 -07:00 · 2023-03-20 22:51:05 +00:00 · 2023-03-14 16:10:11 -07:00 · 2023-03-14 16:09:08 -07:00
3 changed files with 15 additions and 4 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,15 @@
+## 3.7.7 2023-03-20 <codemonium@github>
+
+   ### Changed
+      - Simplify pg_isready usage
+
+
+## 3.7.6 2023-03-14 <toshy@github>
+
+   ### Changed
+      - Remove EXTRA_OPT variable from MySQL/MariaDB check
+
+
 ## 3.7.5 2023-03-02 <dave at tiredofit dot ca>

   ### Added
--- a/README.md
+++ b/README.md
@@ -246,7 +246,7 @@ docker exec -it (whatever your container name is) bash
 ### Manual Backups
 Manual Backups can be performed by entering the container and typing `backup-now`

- Recently there was a request to have the container work with Kukbernetes cron scheduling. This can theoretically be accomplished by setting the container `MODE=MANUAL` and then setting `MANUAL_RUN_FOREVER=FALSE` - You would also want to disable a few features from the upstream base images specifically `CONTAINER_ENABLE_SCHEDULING` and `CONTAINER_ENABLE_MONITORING`. This should allow the container to start, execute a backup by executing and then exit cleanly. An alternative way to running the script is to execute `/etc/services.available/10-db-backup/run`.
+- Recently there was a request to have the container work with Kubernetes cron scheduling. This can theoretically be accomplished by setting the container `MODE=MANUAL` and then setting `MANUAL_RUN_FOREVER=FALSE` - You would also want to disable a few features from the upstream base images specifically `CONTAINER_ENABLE_SCHEDULING` and `CONTAINER_ENABLE_MONITORING`. This should allow the container to start, execute a backup by executing and then exit cleanly. An alternative way to running the script is to execute `/etc/services.available/10-db-backup/run`.

 ### Restoring Databases
 Entering in the container and executing `restore` will execute a menu based script to restore your backups - MariaDB, Postgres, and Mongo supported.
--- a/install/assets/functions/10-db-backup
+++ b/install/assets/functions/10-db-backup
@@ -421,7 +421,7 @@ check_availability() {
            "mysql" )
                counter=0
                export MYSQL_PWD=${DB_PASS}
-                while ! (mysqladmin -u"${DB_USER}" -P"${DB_PORT}" -h"${DB_HOST}" ${mysql_tls_args} ${EXTRA_OPTS} status > /dev/null 2>&1) ; do
+                while ! (mysqladmin -u"${DB_USER}" -P"${DB_PORT}" -h"${DB_HOST}" ${mysql_tls_args} status > /dev/null 2>&1) ; do
                    sleep 5
                    (( counter+=5 ))
                    print_warn "MySQL/MariaDB Server '${DB_HOST}' is not accessible, retrying.. (${counter} seconds so far)"
@@ -437,8 +437,7 @@ check_availability() {
            ;;
            "pgsql" )
                counter=0
-                export PGPASSWORD=${DB_PASS}
-                until pg_isready --dbname=${DB_NAME} --host=${DB_HOST} --port=${DB_PORT} --username=${DB_USER} -q
+                until pg_isready --host=${DB_HOST} --port=${DB_PORT} -q
                do
                    sleep 5
                    (( counter+=5 ))
Author	SHA1	Message	Date
dave@tiredofit.ca	077201cd18	Release 3.7.7 - See CHANGELOG.md	2023-03-20 16:24:23 -07:00
Dave Conroy	eeaf59dc6f	Merge pull request #210 from codemonium/simplify-pg_isready Simplify pg_isready usage	2023-03-20 16:22:13 -07:00
Igor Artemenko	88fe0d6411	Simplify pg_isready usage The pg_isready documentation says that it does not need a correct database name or username to get the server status. In fact, incorrect values result in the server logging failed connection attempts. As a result, when we set DB_NAME to ALL, calls to the check_availability function (which uses pg_isready) cause the server to log the following error: FATAL: database "ALL" does not exist To eliminate this error, this change simplifies the pg_isready call.	2023-03-20 22:51:05 +00:00
dave@tiredofit.ca	366c4759a5	Release 3.7.6 - See CHANGELOG.md	2023-03-14 16:10:11 -07:00
Dave Conroy	37f255ec99	Merge pull request #207 from kamartem/patch-1 Typo correction	2023-03-14 16:09:08 -07:00
Dave Conroy	efa9a678c0	Merge pull request #209 from ToshY/bug/208-mysql-extra-opts-status-check Removed EXTRA_OPTS in MySQL status check	2023-03-14 16:08:53 -07:00
ToshY	68747a4aff	Removed EXTRA_OPTS in MySQL status check	2023-03-14 20:28:05 +01:00
Artem Kamyshansky	cf736278bb	Typo correction	2023-03-12 19:31:04 +03:00