diff --git a/CHANGELOG.md b/CHANGELOG.md index dd845b7..3048e16 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## 4.0.20 2023-11-21 + + ### Changed + - Update base image to support S6 Overlay 3.1.6.2 to solve shutdown issues specifically with MODE=MANUAL and MANUAL_RUN_FOREVER=TRUE + - Add some safety nets for Manual scheduling + + ## 4.0.19 2023-11-20 ### Changed diff --git a/install/assets/dbbackup/template-dbbackup/run b/install/assets/dbbackup/template-dbbackup/run index c28553b..d9bfea9 100755 --- a/install/assets/dbbackup/template-dbbackup/run +++ b/install/assets/dbbackup/template-dbbackup/run @@ -16,7 +16,7 @@ fi trap ctrl_c INT -if [[ "${MODE,,}" =~ "standalone" ]] || [ "${1,,}" = "manual" ] || [ "${1,,}" = "now" ]; then +if [[ "${MODE,,}" =~ "standalone" ]] || [ "${MODE,,}" = "manual" ] || [ "${1,,}" = "manual" ] || [ "${1,,}" = "now" ]; then print_debug "Detected Manual Mode" persist=false backup_job_backup_begin=+0 diff --git a/install/assets/functions/10-db-backup b/install/assets/functions/10-db-backup index 84fedf9..19917e4 100644 --- a/install/assets/functions/10-db-backup +++ b/install/assets/functions/10-db-backup @@ -1160,13 +1160,14 @@ create_schedulers() { instance=$(printf "%02d" $instance) cp -R /assets/dbbackup/template-dbbackup /etc/services.available/dbbackup-"${instance}" sed -i "s|{{BACKUP_NUMBER}}|${instance}|g" /etc/services.available/dbbackup-"${instance}"/run - + if [ "${MODE,,}" = "manual" ] ; then service_stop dbbackup-"${instance}" ; fi cat <> /usr/bin/backup"${instance}"-now #!/bin/bash source /assets/functions/00-container PROCESS_NAME=db-backup${instance} print_info "Starting Manual Backup for db-backup${instance}" -/var/run/s6/legacy-services/dbbackup-${instance}/run now +#/var/run/s6/legacy-services/dbbackup-${instance}/run now +/etc/services.available/dbbackup-${instance}/run now EOF chmod +x /usr/bin/backup"${instance}"-now @@ -1176,11 +1177,11 @@ EOF cat < /usr/bin/backup-now #!/bin/bash -/usr/bin/backup${instance}-now +/usr/bin/backup${instance}-now now EOF else - echo "/usr/bin/backup${instance}-now" >> /usr/bin/backup-now + echo "/usr/bin/backup${instance}-now now" >> /usr/bin/backup-now fi instance=$(echo "${instance} +1" | bc)