Fixed errors picked up by larastan

app/Http/Controllers/BackupController.php

@@ -7,6 +7,7 @@ use DateTime;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Storage;
 use Illuminate\Support\Facades\Validator;
+use Illuminate\Http\JsonResponse;
 
 class BackupController extends Controller
 {
@@ -15,7 +16,7 @@ class BackupController extends Controller
      * Get backup of speedtests
      *
      * @param   Request $request
-     * @return  file
+     * @return  mixed|JsonResponse
      */
     public function backup(Request $request)
     {
@@ -36,7 +37,7 @@ class BackupController extends Controller
      * Retore from a backup
      *
      * @param   Request $request
-     * @return  Response
+     * @return  JsonResponse
      */
     public function restore(Request $request)
     {

app/Http/Controllers/SettingsController.php

@@ -8,6 +8,8 @@ use App\Setting;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Validator;
+use Illuminate\Http\JsonResponse;
+use Illuminate\Support\Collection;
 
 class SettingsController extends Controller
 {
@@ -15,7 +17,7 @@ class SettingsController extends Controller
     /**
      * Return all settings
      *
-     * @return  array
+     * @return  Collection
      */
     public function index()
     {
@@ -37,7 +39,7 @@ class SettingsController extends Controller
      * Store/update a setting
      *
      * @param   Request $request
-     * @return  Response
+     * @return  JsonResponse
      */
     public function store(Request $request)
     {
@@ -72,7 +74,7 @@ class SettingsController extends Controller
      * Bulk store/update a setting
      *
      * @param   Request $request
-     * @return  Response
+     * @return  JsonResponse
      */
     public function bulkStore(Request $request)
     {
@@ -94,7 +96,7 @@ class SettingsController extends Controller
             if(!isset($d['value']) || $d['value'] == null) {
                     $d['value'] = '';
             }
-                
+
             if($d['name'] == 'speedtest_overview_time') {
                 $ok = [ '00', '01', '02', '03', '04', '05', '06', '07', '08', '09', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23' ];
                 if(!in_array($d['value'], $ok)) {
@@ -134,6 +136,12 @@ class SettingsController extends Controller
         return SettingsHelper::getConfig();
     }
 
+
+    /**
+     * Trigger a test of all notification agents
+     *
+     * @return JsonResponse
+     */
     public function testNotification()
     {
         SettingsHelper::testNotification();

app/Http/Controllers/SpeedtestController.php

@@ -11,6 +11,7 @@ use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Validator;
+use Illuminate\Http\JsonResponse;
 
 class SpeedtestController extends Controller
 {
@@ -18,7 +19,7 @@ class SpeedtestController extends Controller
     /**
      * Returns paginated list of speedtests
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function index()
     {
@@ -35,7 +36,7 @@ class SpeedtestController extends Controller
      * Returns speedtest going back 'x' days
      *
      * @param   int     $days
-     * @return  void
+     * @return  JsonResponse
      */
     public function time($days)
     {
@@ -71,7 +72,7 @@ class SpeedtestController extends Controller
      * Returns speedtest failure rate going back 'x' days
      *
      * @param   int     $days
-     * @return  void
+     * @return  JsonResponse
      */
     public function fail($days)
     {
@@ -100,7 +101,7 @@ class SpeedtestController extends Controller
     /**
      * Return latest speedtest
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function latest()
     {
@@ -130,7 +131,7 @@ class SpeedtestController extends Controller
     /**
      * Queue a new speedtest
      *
-     * @return Response
+     * @return JsonResponse
      */
     public function run()
     {
@@ -151,7 +152,7 @@ class SpeedtestController extends Controller
     /**
      * Delete all speedtests from db
      *
-     * @return Response
+     * @return JsonResponse
      */
     public function deleteAll()
     {
@@ -175,7 +176,7 @@ class SpeedtestController extends Controller
      * Delete a specific speedtest from the database
      *
      * @param Speedtest $speedtest
-     * @return boolean
+     * @return JsonResponse
      */
     public function delete(Speedtest $speedtest)
     {

app/Http/Controllers/UpdateController.php

@@ -5,6 +5,7 @@ namespace App\Http\Controllers;
 use Exception;
 use Updater;
 use Illuminate\Http\Request;
+use Illuminate\Http\JsonResponse;
 
 class UpdateController extends Controller
 {
@@ -12,7 +13,7 @@ class UpdateController extends Controller
     /**
      * Check for new update
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function checkForUpdate()
     {
@@ -25,7 +26,7 @@ class UpdateController extends Controller
     /**
      * Download new update
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function downloadUpdate()
     {
@@ -47,7 +48,7 @@ class UpdateController extends Controller
     /**
      * Trigger update extraction
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function extractUpdate()
     {
@@ -69,22 +70,22 @@ class UpdateController extends Controller
     /**
      * Trigger update file move
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function moveUpdate()
     {
-        $cp = Updater::updateFiles();
+        Updater::updateFiles();
 
         return response()->json([
             'method' => 'copy latest version',
-            'success' => $cp,
+            'success' => null,
         ], 200);
     }
 
     /**
      * Get local changelog
      *
-     * @return  Response
+     * @return  JsonResponse
      */
     public function changelog()
     {