From 1fd033b3c1398986a461b21db386166f31c6304b Mon Sep 17 00:00:00 2001 From: Henry Whitaker Date: Sun, 7 Mar 2021 09:46:44 +0000 Subject: [PATCH] Grab all settings instead of new query for each one --- app/Helpers/SettingsHelper.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/Helpers/SettingsHelper.php b/app/Helpers/SettingsHelper.php index 8acffb36..1ff03877 100644 --- a/app/Helpers/SettingsHelper.php +++ b/app/Helpers/SettingsHelper.php @@ -9,6 +9,7 @@ use Carbon\Carbon; class SettingsHelper { + private static $settings = null; /** * Get a Setting object by name @@ -18,12 +19,16 @@ class SettingsHelper */ public static function get(String $name) { - $name = Setting::where('name', $name)->get(); + if (self::$settings === null) { + self::$settings = Setting::get(); + } + + $name = self::$settings->where('name', $name); if (sizeof($name) == 0) { return false; } else if (sizeof($name) == 1) { - return $name[0]; + return $name->first(); } else { $name = $name->keyBy('name'); return $name->all();